[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

/ok-to-test

Codecov Report

Merging #7310 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #7310      +/-   ##
==========================================
- Coverage   37.47%   37.47%   -0.01%     
==========================================
  Files         146      146              
  Lines        8869     8870       +1     
==========================================
  Hits         3324     3324              
- Misses       5140     5141       +1     
  Partials      405      405              

All Times minikube: [ 63.843747 64.571736 63.382713]
All Times Minikube (PR 7310): [ 65.498433 65.128930 63.318467]

Average minikube: 63.932732
Average Minikube (PR 7310): 64.648610

Averages Time Per Log

+----------------------+-----------+--------------------+
|         LOG          | MINIKUBE  | MINIKUBE (PR 7310) |
+----------------------+-----------+--------------------+
| minikube v           |  0.226193 |           0.204853 |
| Creating kvm2        | 40.661609 |          40.574316 |
| Preparing Kubernetes | 21.456828 |          21.936304 |
| Pulling images       |           |                    |
| Launching Kubernetes |           |                    |
| Waiting for cluster  |           |                    |
+----------------------+-----------+--------------------+

@medyagh - question: on Linux, should we expose the true Docker IP & port, or is it better to always use 127.0.0.1 for consistency?

@tstromberg

@medyagh - question: on Linux, should we expose the true Docker IP & port, or is it better to always use 127.0.0.1 for consistency?

For sure it is better to use the real ip.
So at least on linux we have a true service port experience.
@josedonizetti told me about a POC that we could implement real ip for Mac in the future.

So I would consider macOs networking a limitation that we will eventually make it as nice as Linux.

Merging and following up with a second PR to address shortcomings.